aboutsummaryrefslogtreecommitdiff
path: root/src/base_tab
diff options
context:
space:
mode:
authorLoic Guegan <manzerbredes@mailbox.org>2023-05-10 10:49:31 +0200
committerLoic Guegan <manzerbredes@mailbox.org>2023-05-10 10:49:31 +0200
commita9b9ed95f39cff40710e74ed81fdedee1cfad9e2 (patch)
treeacd01294ad1ae6f88b7515d6a6d8ac790f444f1d /src/base_tab
parentff671f2171396088210600bab39ad9631e0d1daf (diff)
Remove all warnings from source code
Diffstat (limited to 'src/base_tab')
-rw-r--r--src/base_tab/BaseGameTab.cpp2
-rw-r--r--src/base_tab/BaseImportTab.cpp4
-rw-r--r--src/base_tab/BaseTab.cpp2
-rw-r--r--src/base_tab/GameListManager.cpp4
-rw-r--r--src/base_tab/GameListManager.hpp2
5 files changed, 11 insertions, 3 deletions
diff --git a/src/base_tab/BaseGameTab.cpp b/src/base_tab/BaseGameTab.cpp
index dfa5a0a..b14f160 100644
--- a/src/base_tab/BaseGameTab.cpp
+++ b/src/base_tab/BaseGameTab.cpp
@@ -26,6 +26,7 @@ BaseGameTab::BaseGameTab(wxFrame *parent, std::shared_ptr<GameBase> base)
void BaseGameTab::OnApplyFilter(wxCommandEvent &event){
+ UNUSED(event);
wxString terms=search_terms->GetValue();
if(terms.length()>0){
glm->Filter(terms.ToStdString());
@@ -35,6 +36,7 @@ void BaseGameTab::OnApplyFilter(wxCommandEvent &event){
}
void BaseGameTab::OnDelete(wxCommandEvent &event) {
+ UNUSED(event);
for(auto i: glm->GetSelectedItems()){
game_list->SetItemState(i, 0, wxLIST_STATE_SELECTED); // First deselect
long gameid=glm->GetItemGameId(i);
diff --git a/src/base_tab/BaseImportTab.cpp b/src/base_tab/BaseImportTab.cpp
index 3e93633..13ded29 100644
--- a/src/base_tab/BaseImportTab.cpp
+++ b/src/base_tab/BaseImportTab.cpp
@@ -26,6 +26,7 @@ TabBase_TabImport(parent), main_tab(main_tab), base(db)
}
void BaseImportTab::OnImportDatabase(wxCommandEvent &event){
+ UNUSED(event);
if(std::find(databases_to_import.begin(), databases_to_import.end(), selected_base->GetFilePath()) == databases_to_import.end()){
databases_to_import.push_back(selected_base->GetFilePath());
selected_games_to_import.erase(selected_base->GetFilePath());
@@ -72,6 +73,7 @@ void BaseImportTab::RefreshImportLists(){
}
void BaseImportTab::OnImportSelection(wxCommandEvent &event){
+ UNUSED(event);
if(std::find(databases_to_import.begin(), databases_to_import.end(), selected_base->GetFilePath()) == databases_to_import.end()){
long selected = -1;
while ((selected = game_list->GetNextItem(selected, wxLIST_NEXT_ALL,
@@ -96,6 +98,7 @@ void BaseImportTab::OnImportSelection(wxCommandEvent &event){
}
void BaseImportTab::OnImportGame(wxCommandEvent &event){
+ UNUSED(event);
TabInfos *game_tab=(TabInfos*)opened_game_list->GetClientData(opened_game_list->GetSelection());
std::shared_ptr<Game> g=game_tab->GetGame();
if(std::find(games_to_import.begin(), games_to_import.end(), g) == games_to_import.end()){ wxLogDebug("Import!");
@@ -106,6 +109,7 @@ void BaseImportTab::OnImportGame(wxCommandEvent &event){
}
void BaseImportTab::OnLoad(wxCommandEvent &event){
+ UNUSED(event);
TabInfos *game_tab=(TabInfos*)opened_db_list->GetClientData(opened_db_list->GetSelection());
// Load all games (for now :)
diff --git a/src/base_tab/BaseTab.cpp b/src/base_tab/BaseTab.cpp
index 1342c49..466c523 100644
--- a/src/base_tab/BaseTab.cpp
+++ b/src/base_tab/BaseTab.cpp
@@ -26,6 +26,7 @@ BaseTab::BaseTab(wxFrame *parent, std::string base_file)
this->Bind(wxEVT_BUTTON, &BaseTab::OnSave, this, ID_SAVE_BUTTON);
this->Bind(wxEVT_LIST_ITEM_ACTIVATED, &BaseTab::OnOpenGame, this, ID_TABGAMES_GAME_LIST);
Bind(REFRESH_MANAGE_TAB,[p=this](wxCommandEvent &e){
+ UNUSED(e);
p->manage_tab->RefreshInformations();
p->is_dirty=p->manage_tab->HasPendingEvents(); // Refresh tab dirty flag
},wxID_ANY);
@@ -46,6 +47,7 @@ void BaseTab::Refresh(){
}
void BaseTab::OnSave(wxCommandEvent &event) {
+ UNUSED(event);
SHOW_DIALOG_BUSY("Apply all changes. Take a coffee, this process can takes time...");
// First import games
std::vector<std::shared_ptr<Game>> new_games=games_tab->GetEditedGames();
diff --git a/src/base_tab/GameListManager.cpp b/src/base_tab/GameListManager.cpp
index 971e486..22630ec 100644
--- a/src/base_tab/GameListManager.cpp
+++ b/src/base_tab/GameListManager.cpp
@@ -1,7 +1,7 @@
#include "GameListManager.hpp"
-GameListManager::GameListManager(wxListCtrl *game_list): game_list(game_list), game_counter(0) {
+GameListManager::GameListManager(wxListCtrl *game_list): game_counter(0), game_list(game_list) {
game_list->InsertColumn(0, L"Id", wxLIST_FORMAT_LEFT, 50);
game_list->InsertColumn(1, L"White", wxLIST_FORMAT_LEFT, 200);
game_list->InsertColumn(2, L"Black", wxLIST_FORMAT_LEFT, 200);
@@ -117,7 +117,7 @@ long GameListManager::GetItemGameId(long item){
void GameListManager::Filter(std::string terms){
ClearDisplayedRow();
- for(int i=0;i<rows.size();i++){
+ for(std::size_t i=0;i<rows.size();i++){
RType row=rows[i];
if(TERMS_IN(White) ||
TERMS_IN(Black) ||
diff --git a/src/base_tab/GameListManager.hpp b/src/base_tab/GameListManager.hpp
index 3499aac..d48ac36 100644
--- a/src/base_tab/GameListManager.hpp
+++ b/src/base_tab/GameListManager.hpp
@@ -8,7 +8,7 @@
#define BG_OPEN(INDEX) game_list->SetItemBackgroundColour(INDEX, *wxGREEN)
#define BG_DELETE(INDEX) game_list->SetItemBackgroundColour(INDEX, *wxRED)
#define BG_IMPORT(INDEX) game_list->SetItemBackgroundColour(INDEX, *wxBLUE)
-#define DISPLAY_ALL_ROWS() {for(int i=0;i<rows.size();i++){DisplayRow(i);}}
+#define DISPLAY_ALL_ROWS() {for(std::size_t i=0;i<rows.size();i++){DisplayRow(i);}}
///@brief Column content type
typedef std::string CType;